From: Daniel Vetter Subject: Re: [PATCH] drm/i915: enable IPS for bpp <= 24 Date: Mon, 5 Aug 2013 07:32:36 +0200 Message-ID: <20130805053236.GH22035@phenom.ffwll.local> References: <1374772010-3115-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CAD8E5CB1 for ; Sun, 4 Aug 2013 22:33:24 -0700 (PDT) Received: by mail-wi0-f179.google.com with SMTP id hr7so1085199wib.12 for ; Sun, 04 Aug 2013 22:32:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 31, 2013 at 05:35:53PM -0300, Paulo Zanoni wrote: > 2013/7/25 Jesse Barnes : > > Art confirms that this should work fine. Since most panels are 18bpp > > with dithering from 24bpp, the existing code wouldn't be enabled in most > > cases. > > > > I previously said I tested this in the past and it didn't work. So > today I tested it again and I discovered that the problem is that if I > configure X to use DefaultDepth 16, my eDP monitor won't work *at > all*, even with IPS disabled. Everything else seems to work. > > Sorry for the wrong information. I guess this is another case of https://bugzilla.kernel.org/show_bug.cgi?id=59841 Care to test the attached patch there? > Reviewed-by: Paulo Zanoni Merged, thanks for the patch&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch