From: Daniel Vetter Subject: Re: [PATCH] drm/i915: make user mode sync polarity setting explicit Date: Mon, 5 Aug 2013 08:15:59 +0200 Message-ID: <20130805061559.GP22035@phenom.ffwll.local> References: <1375180592-16514-1-git-send-email-imre.deak@intel.com> <20130730105706.GA2616@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by gabe.freedesktop.org (Postfix) with ESMTP id C6342E5DB9 for ; Sun, 4 Aug 2013 23:15:52 -0700 (PDT) Received: by mail-we0-f178.google.com with SMTP id u57so2101692wes.37 for ; Sun, 04 Aug 2013 23:15:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130730105706.GA2616@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 30, 2013 at 11:57:06AM +0100, Chris Wilson wrote: > On Tue, Jul 30, 2013 at 01:36:32PM +0300, Imre Deak wrote: > > Userspace can pass a mode with an unspecified vsync/hsync polarity > > setting. All encoders in the Intel driver take this to mean a negative > > polarity setting. The HW readout/state checker code on the other hand > > needs these flags to be explicitly set, otherwise the state checker will > > WARN about the mismatch. > > > > Get rid of the WARN by making the polarity setting explicit in the > > adjusted mode flags based on the requested mode flags. This will keep > > the existing behavior otherwise. > > > > Note that we could guess from the other timing parameters whether the > > user wanted a VESA or other standard mode and set the polarity > > accordingly. This is what the NV driver does > > (drivers/gpu/drm/nouveau/dispnv04/crtc.c), but I think that's not very > > exact and would change the existing behavior of the Intel driver. > > Right, don't guess. If the user wanted the standard mode, then the flags > would have been taken from the standard modeline. > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65442 > > You can add a tested-by here for qa. > > > Signed-off-by: Imre Deak > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch