From: Daniel Vetter Subject: Re: [PATCH 3/3] drm: Remove drm_mode_validate_clocks Date: Mon, 5 Aug 2013 08:21:25 +0200 Message-ID: <20130805062125.GR22035@phenom.ffwll.local> References: <1375230233-4256-1-git-send-email-marcheu@chromium.org> <1375230233-4256-3-git-send-email-marcheu@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 40B08E5BF9 for ; Sun, 4 Aug 2013 23:21:19 -0700 (PDT) Received: by mail-wg0-f53.google.com with SMTP id c11so2097806wgh.20 for ; Sun, 04 Aug 2013 23:21:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375230233-4256-3-git-send-email-marcheu@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: =?iso-8859-1?Q?St=E9phane?= Marchesin Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 30, 2013 at 05:23:53PM -0700, St=E9phane Marchesin wrote: > Signed-off-by: St=E9phane Marchesin Ben originally picked this up into his danvet-on-vactaion tree, but since it's for core drm it needs to go in through Dave's tree. -Daniel > --- > drivers/gpu/drm/drm_modes.c | 37 ------------------------------------- > include/drm/drm_crtc.h | 3 --- > 2 files changed, 40 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index a6729bf..504a602 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -923,43 +923,6 @@ void drm_mode_validate_size(struct drm_device *dev, > EXPORT_SYMBOL(drm_mode_validate_size); > = > /** > - * drm_mode_validate_clocks - validate modes against clock limits > - * @dev: DRM device > - * @mode_list: list of modes to check > - * @min: minimum clock rate array > - * @max: maximum clock rate array > - * @n_ranges: number of clock ranges (size of arrays) > - * > - * LOCKING: > - * Caller must hold a lock protecting @mode_list. > - * > - * Some code may need to check a mode list against the clock limits of t= he > - * device in question. This function walks the mode list, testing to ma= ke > - * sure each mode falls within a given range (defined by @min and @max > - * arrays) and sets @mode->status as needed. > - */ > -void drm_mode_validate_clocks(struct drm_device *dev, > - struct list_head *mode_list, > - int *min, int *max, int n_ranges) > -{ > - struct drm_display_mode *mode; > - int i; > - > - list_for_each_entry(mode, mode_list, head) { > - bool good =3D false; > - for (i =3D 0; i < n_ranges; i++) { > - if (mode->clock >=3D min[i] && mode->clock <=3D max[i]) { > - good =3D true; > - break; > - } > - } > - if (!good) > - mode->status =3D MODE_CLOCK_RANGE; > - } > -} > -EXPORT_SYMBOL(drm_mode_validate_clocks); > - > -/** > * drm_mode_prune_invalid - remove invalid modes from mode list > * @dev: DRM device > * @mode_list: list of modes to check > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index fa12a2f..32e0820 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -930,9 +930,6 @@ extern void drm_mode_list_concat(struct list_head *he= ad, > extern void drm_mode_validate_size(struct drm_device *dev, > struct list_head *mode_list, > int maxX, int maxY, int maxPitch); > -extern void drm_mode_validate_clocks(struct drm_device *dev, > - struct list_head *mode_list, > - int *min, int *max, int n_ranges); > extern void drm_mode_prune_invalid(struct drm_device *dev, > struct list_head *mode_list, bool verbose); > extern void drm_mode_sort(struct list_head *mode_list); > -- = > 1.8.3 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch