From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] i915: fix ACPI _DSM warning Date: Mon, 5 Aug 2013 09:19:52 +0200 Message-ID: <20130805071952.GU22035@phenom.ffwll.local> References: <1375374088-1792-1-git-send-email-lekensteyn@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C5E3E6302 for ; Mon, 5 Aug 2013 00:19:45 -0700 (PDT) Received: by mail-wi0-f179.google.com with SMTP id hr7so1156540wib.12 for ; Mon, 05 Aug 2013 00:19:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375374088-1792-1-git-send-email-lekensteyn@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Peter Wu Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 01, 2013 at 06:21:28PM +0200, Peter Wu wrote: > Since commit 29a241c (ACPICA: Add argument typechecking for all > predefined ACPI names), _DSM parameters are validated which trigger the > following warning: > > ACPI Warning: \_SB_.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95) > ACPI Warning: \_SB_.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95) > ACPI Warning: \_SB_.PCI0.P0P2.PEGP._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95) > ACPI Warning: \_SB_.PCI0.P0P2.PEGP._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95) > > As the Intel _DSM method seems to ignore this parameter, let's comply to > the ACPI spec and use a Package instead. > > Signed-off-by: Peter Wu > --- > What is this code useful for? It seems unfinished, all it does it > printing some information when a mux is available, but besides that > there is no interaction with the driver. Dunno how it all works exactly, but yours is not the only report: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=32602 Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch