From: Daniel Vetter Subject: Re: [PATCH] [v4] drm/i915/hsw: Change default LLC age to 3 Date: Mon, 5 Aug 2013 10:21:25 +0200 Message-ID: <20130805082125.GD22035@phenom.ffwll.local> References: <1375685249-5886-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id E8A5AE6767 for ; Mon, 5 Aug 2013 01:21:19 -0700 (PDT) Received: by mail-wi0-f170.google.com with SMTP id hi8so1226678wib.5 for ; Mon, 05 Aug 2013 01:21:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375685249-5886-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sun, Aug 04, 2013 at 11:47:29PM -0700, Ben Widawsky wrote: > The default LLC age was changed: > commit 0d8ff15e9a15f2b393e53337a107b7a1e5919b6d > Author: Ben Widawsky > Date: Thu Jul 4 11:02:03 2013 -0700 > > drm/i915/hsw: Set correct Haswell PTE encodings. > > On the surface it would seem setting a default age wouldn't matter > because all GEM BOs are aged similarly, so the order in which objects > are evicted would not be subject to aging. The current working theory as > to why this caused a regression though is that LLC is a bit special in > that it is shared with the CPU. Presumably (not verified) the CPU > fetches cachelines with age 3, and therefore recently cached GPU objects > would be evicted before similar CPU object first when the LLC is full. > It stands to reason therefore that this would negatively impact CPU > bound benchmarks - but those seem to be low on the priority list. > > eLLC OTOH does not have this same property as LLC. It should be used > entirely for the GPU, and so the age really shouldn't matter. > Furthermore, we have no evidence to suggest one is better than another > on eLLC. Since we've never properly supported eLLC before no, there > should be no regression. If the GPU client really wants "younger" > objects, they should use MOCS. > > v2: Drop the extra #define (Chad) > > v3: Actually git add > > v4: Pimped commit message > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67062 > Signed-off-by: Ben Widawsky > Reviewed-by: Chad Versace Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch