From: Daniel Vetter Subject: Re: [PATCH v2 12/17] drm/i915: Store the watermark latency values in dev_priv Date: Mon, 5 Aug 2013 18:25:54 +0200 Message-ID: <20130805162554.GN22035@phenom.ffwll.local> References: <1375363135-20618-1-git-send-email-ville.syrjala@linux.intel.com> <1375363135-20618-13-git-send-email-ville.syrjala@linux.intel.com> <20130801142356.GA21614@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTP id C66CDE73A8 for ; Mon, 5 Aug 2013 09:25:47 -0700 (PDT) Received: by mail-wg0-f54.google.com with SMTP id e12so1527562wgh.21 for ; Mon, 05 Aug 2013 09:25:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130801142356.GA21614@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 01, 2013 at 03:23:56PM +0100, Chris Wilson wrote: > On Thu, Aug 01, 2013 at 04:18:50PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Rather than having to read the latency values out every time, just > > store them in dev_priv. > > = > > On ILK and IVB there is a difference between some of the latency > > values for different planes, so store the latency values for each > > plane type separately, and apply the necesary fixups during init. > > = > > v2: Fix some checkpatch complaints > = > As you are now storing these, it would also be useful to add a debugfs > file to dump them out for sanity checking. I leave the request to adjust > them via debugfs to somebody else ;-) I guess since this is ramping up to be the furture plane_config we might just need a bit of plane config dump support. Of course we need to be careful to not redump on every nuclear pageflip, but only if something interesting changes ... Or did you just think of the underlying latency values that steer the wm comuptation? -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch