From: Daniel Vetter Subject: Re: [PATCH 13/29] drm/i915: eliminate dead domain clearing on reset Date: Mon, 5 Aug 2013 19:13:42 +0200 Message-ID: <20130805171342.GQ22035@phenom.ffwll.local> References: <1375315222-4785-14-git-send-email-ben@bwidawsk.net> <1375721204-1323-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E2E4E741F for ; Mon, 5 Aug 2013 10:13:36 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id m46so2692849wev.22 for ; Mon, 05 Aug 2013 10:13:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375721204-1323-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 05, 2013 at 09:46:44AM -0700, Ben Widawsky wrote: > The code itself is no longer accurate without updating once we have > multiple address space since clearing the domains of every object > requires scanning the inactive list for all VMs. > > "This code is dead. Just remove it rather than port it to vma." - Chris > Wilson > > Recommended-by: Chris Wilson > Signed-off-by: Ben Widawsky Thanks for resend, slurped into dinq. I'd like to take a little break here now and resume merging tomorrow - I've merge over 50 patches just today ;-) -Daniel > --- > drivers/gpu/drm/i915/i915_gem.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index d37f5c0..3b9558f 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -2290,20 +2290,12 @@ void i915_gem_restore_fences(struct drm_device *dev) > void i915_gem_reset(struct drm_device *dev) > { > struct drm_i915_private *dev_priv = dev->dev_private; > - struct i915_address_space *vm = &dev_priv->gtt.base; > - struct drm_i915_gem_object *obj; > struct intel_ring_buffer *ring; > int i; > > for_each_ring(ring, dev_priv, i) > i915_gem_reset_ring_lists(dev_priv, ring); > > - /* Move everything out of the GPU domains to ensure we do any > - * necessary invalidation upon reuse. > - */ > - list_for_each_entry(obj, &vm->inactive_list, mm_list) > - obj->base.read_domains &= ~I915_GEM_GPU_DOMAINS; > - > i915_gem_restore_fences(dev); > } > > -- > 1.8.3.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch