Received: from eggs.gnu.org ([2001:4830:134:3::10]:57810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6dTM-0002UQ-E0 for qemu-devel@nongnu.org; Tue, 06 Aug 2013 05:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6dTG-0008Vr-Eb for qemu-devel@nongnu.org; Tue, 06 Aug 2013 05:22:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6dTG-0008Vi-6C for qemu-devel@nongnu.org; Tue, 06 Aug 2013 05:22:26 -0400 Date: Tue, 6 Aug 2013 17:22:05 +0800 From: Fam Zheng Message-ID: <20130806092205.GA24514@T430s.nay.redhat.com> References: <1375458782-14888-1-git-send-email-benoit@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1375458782-14888-1-git-send-email-benoit@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, 08/02 17:53, Beno=EEt Canet wrote: > This patchset implement continous leaky bucket throttling. >=20 > It works mostly on the general case. > The exception is where the load is composed of both reads and writes an= d two > limits iops_rd and iops_wr are set. > The resulting iops are a little above half of the given limits. > I tried various strategies to avoid this: two timer, two throttled requ= est > queues or even a different algorithm using a priority queue. > The problem is still the same in every version of the code: reads and w= rites > operation seems entangled. >=20 > Beno=EEt Canet (2): > throttle: Add a new throttling API implementing continuus leaky s/continuus/continuous/ > bucket. > block: Enable the new throttling code in the block layer. >=20 > block.c | 316 ++++++++------------------------ > block/qapi.c | 21 +-- > blockdev.c | 115 ++++++------ > include/block/block.h | 1 - > include/block/block_int.h | 33 +--- > include/qemu/throttle.h | 111 ++++++++++++ > util/Makefile.objs | 1 + > util/throttle.c | 436 +++++++++++++++++++++++++++++++++++++= ++++++++ > 8 files changed, 698 insertions(+), 336 deletions(-) > create mode 100644 include/qemu/throttle.h > create mode 100644 util/throttle.c >=20 > --=20 > 1.7.10.4 >=20 >=20 --=20 Fam