From: Damien Lespiau Subject: Re: [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe() Date: Tue, 6 Aug 2013 19:18:04 +0100 Message-ID: <20130806181804.GC21449@strange.amr.corp.intel.com> References: <1375464180-7259-1-git-send-email-damien.lespiau@intel.com> <1375464180-7259-7-git-send-email-damien.lespiau@intel.com> <20130805175045.GZ5004@intel.com> <20130806174909.GB21449@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 20E4EE6229 for ; Tue, 6 Aug 2013 11:18:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 06, 2013 at 08:01:34PM +0200, Daniel Vetter wrote: > On Tue, Aug 6, 2013 at 7:49 PM, Damien Lespiau = wrote: > > On Mon, Aug 05, 2013 at 08:50:45PM +0300, Ville Syrj=E4l=E4 wrote: > >> On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote: > >> > set_frame() wraps the write_frame() vfunc. Be consistent and name the > >> > wrapping function like the vfunc being called. > >> > > >> > It's doubly confusing as we also have a set_infoframes() vfunc and > >> > set_infoframe() doesn't wrap it. > >> > >> I guess the logic was > >> set_infoframes -> set__infoframe -> set_infoframe -> write_info= frame > >> > >> But I don't really have an opinion on which is better, so: > > > > Meh, doesn't really matter :) I'll just drop this patch. > = > I think it makes sense and more clearly distinguishes set_infoframes > from from writing them. So would have merged ... Will resend with the new series then :) -- = Damien