From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Silence a sparse warning Date: Wed, 7 Aug 2013 14:20:30 +0200 Message-ID: <20130807122030.GW22035@phenom.ffwll.local> References: <1375877512-25816-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E439E64C8 for ; Wed, 7 Aug 2013 05:20:23 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e52so801662eek.16 for ; Wed, 07 Aug 2013 05:20:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375877512-25816-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 07, 2013 at 03:11:52PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > drivers/gpu/drm/i915/i915_debugfs.c:2136:3: warning: symbol > 'i915_debugfs_files' was not declared. Should it be static? > = > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i= 915_debugfs.c > index d2935b4..5d52a23 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2130,7 +2130,7 @@ static struct drm_info_list i915_debugfs_list[] =3D= { > }; > #define I915_DEBUGFS_ENTRIES ARRAY_SIZE(i915_debugfs_list) > = > -struct i915_debugfs_files { > +static struct i915_debugfs_files { > const char *name; > const struct file_operations *fops; > } i915_debugfs_files[] =3D { > -- = > 1.8.1.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch