From: Ben Widawsky Subject: Re: [PATCH 21/29] drm/i915: mm_list is per VMA Date: Thu, 8 Aug 2013 11:10:17 -0700 Message-ID: <20130808181017.GB2081@bwidawsk.net> References: <1375315222-4785-1-git-send-email-ben@bwidawsk.net> <1375315222-4785-22-git-send-email-ben@bwidawsk.net> <20130806193841.GG22035@phenom.ffwll.local> <20130807002805.GB18216@bwidawsk.net> <20130807205214.GC22035@phenom.ffwll.local> <20130808043200.GA15464@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A267E5C97 for ; Thu, 8 Aug 2013 11:10:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 08, 2013 at 08:46:46AM +0200, Daniel Vetter wrote: > On Thu, Aug 8, 2013 at 6:32 AM, Ben Widawsky wrote: > > You killed a BUG in i915_gem_retire_requests_ring, shouldn't that be a WARN or are you in the business of completely killing assertions now :p? > > Yeah, and my little commit message annotation even explained that it's > fully redundant since the move_to_inactive function called on the next > line has the exact same check ;-) Heh, I realized this as I was dozing off last night... "didn't danvet point that out already." Oh well, at least I passed the test. -- Ben Widawsky, Intel Open Source Technology Center