Return-Path: From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haynes , Vinod Koul , Takashi Iwai Subject: [ 01/25] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION Date: Thu, 8 Aug 2013 18:41:37 -0700 Message-Id: <20130809013649.348474206@linuxfoundation.org> In-Reply-To: <20130809013649.057678051@linuxfoundation.org> References: <20130809013649.057678051@linuxfoundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vinod Koul commit a8d30608eaed6cc759b8e2e8a8bbbb42591f797f upstream. the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the return value was never updated for this call assign return value from put_user() Reported-by: Haynes Signed-off-by: Vinod Koul Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -582,7 +582,7 @@ static long snd_compr_ioctl(struct file mutex_lock(&stream->device->lock); switch (_IOC_NR(cmd)) { case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION): - put_user(SNDRV_COMPRESS_VERSION, + retval = put_user(SNDRV_COMPRESS_VERSION, (int __user *)arg) ? -EFAULT : 0; break; case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):