From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: Remove node only when allocated Date: Sat, 10 Aug 2013 09:45:05 +0100 Message-ID: <20130810084505.GD3561@cantiga.alporthouse.com> References: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> <1376111536-12461-3-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 33BD5E5F64 for ; Sat, 10 Aug 2013 01:45:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376111536-12461-3-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 09, 2013 at 10:12:14PM -0700, Ben Widawsky wrote: > In upcoming code, it will be possible for a vma to have been created, > but no space reserved for it in the address space. The drm_mm semantics > are such that trying to remove an unallocated node is not allowed. But not allocated during unbind, i.e. calling unbind() before bind()? That seems scary enough. -Chris -- Chris Wilson, Intel Open Source Technology Centre