From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: Convert execbuf code to use vmas Date: Sat, 10 Aug 2013 10:01:35 +0100 Message-ID: <20130810090135.GF3561@cantiga.alporthouse.com> References: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> <1376111536-12461-5-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 1460BE5D37 for ; Sat, 10 Aug 2013 02:01:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376111536-12461-5-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > static int > -need_reloc_mappable(struct drm_i915_gem_object *obj) > +need_reloc_mappable(struct i915_vma *vma) > { > - struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; > - return entry->relocation_count && !use_cpu_reloc(obj); > + struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; > + return entry->relocation_count && !use_cpu_reloc(vma->obj); > } need_reloc_mappable() should return false if ppgtt. If we need to use a GTT reloc that will setup a separate ggtt entry i.e. it doesn't influence the decision during reservation. -Chris -- Chris Wilson, Intel Open Source Technology Centre