From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: Convert execbuf code to use vmas Date: Sat, 10 Aug 2013 10:10:57 +0100 Message-ID: <20130810091057.GG3561@cantiga.alporthouse.com> References: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> <1376111536-12461-5-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 99CDFE5F57 for ; Sat, 10 Aug 2013 02:11:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376111536-12461-5-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > In order to transition more of our code over to using a VMA instead of > an pair - we must have the vma accessible at execbuf time. Up > until now, we've only had a VMA when actually binding an object. > > The previous patch helped handle the distinction on bound vs. unbound. > This patch will help us catch leaks, and other issues before we actually > shuffle a bunch of stuff around. > > This attempts to convert all the execbuf code to speak in vmas. Since > the execbuf code is very self contained it was a nice isolated > conversion. > > The meat of the code is about turning eb_objects into eb_vma, and then > wiring up the rest of the code to use vmas instead of obj, vm pairs. > > Unfortunately, to do this, we must move the exec_list link from the obj > structure. This list is reused in the eviction code, so we must also > modify the eviction code to make this work. > > v2: Release table lock early, and two a 2 phase vma lookup to avoid > having to use a GFP_ATOMIC. (Chris) > > v3: s/obj_exec_list/obj_exec_link/ > Updates to address > commit 6d2b888569d366beb4be72cacfde41adee2c25e1 > Author: Chris Wilson > Date: Wed Aug 7 18:30:54 2013 +0100 > > drm/i915: List objects allocated from stolen memory in debugfs > > Signed-off-by: Ben Widawsky One thing to check&confirm is that any differences in gem_exec_lut_handle are within the noise. -Chris -- Chris Wilson, Intel Open Source Technology Centre