From: Daniel Vetter Subject: Re: [PATCH 2/7] lib/drmtest: Add drmtest_subtest_block macro Date: Mon, 12 Aug 2013 12:27:25 +0200 Message-ID: <20130812102725.GV31670@phenom.ffwll.local> References: <1376298601-18641-1-git-send-email-daniel.vetter@ffwll.ch> <1376298601-18641-3-git-send-email-daniel.vetter@ffwll.ch> <20130812091506.GA21651@cantiga.alporthouse.com> <20130812092649.GS31670@phenom.ffwll.local> <20130812102024.GU31670@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) by gabe.freedesktop.org (Postfix) with ESMTP id C94B7E694A for ; Mon, 12 Aug 2013 03:27:18 -0700 (PDT) Received: by mail-ee0-f53.google.com with SMTP id b15so3418303eek.26 for ; Mon, 12 Aug 2013 03:27:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130812102024.GU31670@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 12, 2013 at 12:20:24PM +0200, Daniel Vetter wrote: > On Mon, Aug 12, 2013 at 11:26:49AM +0200, Daniel Vetter wrote: > > On Mon, Aug 12, 2013 at 10:15:06AM +0100, Chris Wilson wrote: > > > On Mon, Aug 12, 2013 at 11:09:56AM +0200, Daniel Vetter wrote: > > > > Doesn't do more than an if (drmtest_run_test(name)) right now, but > > > > as soon as we get a bit of infrastructure to handle test failures and > > > > skipping, this will get more interesting. > > > > > > Just use drm_subtest("name") { } > > > > > > drm_subtest_block() reads like a function and so one expects "block" to > > > be a verb. > > > > The intention was to make clear that the macro expects a C code block > > afterwards. See the later patches for some of the fun I add ... I see that > > the _block suffix can be misread, but tbh I don't have any other ideas > > that might properly convey what this thing is. The 2nd best I could think > > of is do_subtest("name") similar to do {} while (). But that's not great > > either. > > Ok, I've applied the following three bikesheds onto my tree: > - s/drmtest_run_subtest/__drmtest_run_subtest/ since that fuction is now > internal to drmtest.c (but needs to be in the header due to the fancy > macro). > - s/drmtest_subtest_block/drmtest/subtest/ ... see above. > - s/drmtest_/igt_/ just because (suggested by Chris on irc). One more on top: - s/return igt_retval()/igt_exit()/ I'll push this one the US has woken up an had a chance to comment. There's too much tree-wide sed and sed-like stuff in this series now. Latest patches pushed to my private repo. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch