From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Initialize seqno for VECS too Date: Tue, 13 Aug 2013 09:02:45 +0200 Message-ID: <20130813070157.GA9296@phenom.ffwll.local> References: <1376351584-733-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id E0DE4E6872 for ; Tue, 13 Aug 2013 00:02:41 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id b45so4073400eek.1 for ; Tue, 13 Aug 2013 00:02:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376351584-733-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 12, 2013 at 04:53:03PM -0700, Ben Widawsky wrote: > Cc: Mika Kuoppala > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65387 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67198 > Signed-off-by: Ben Widawsky Tested-by: lu hua (both bug reports) Please pimp the commit message as discussion on irc (reply with just the text is ok). Strictly speaking we initialize the 3rd mbox for the 4th ring here (which ofc is the vebox one for all rings != vebox). And also please mention the effects of this bug, i.e. how it blows up. Thanks, Daniel > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 10c2aaa..665602f 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -1592,6 +1592,8 @@ void intel_ring_init_seqno(struct intel_ring_buffer *ring, u32 seqno) > if (INTEL_INFO(ring->dev)->gen >= 6) { > I915_WRITE(RING_SYNC_0(ring->mmio_base), 0); > I915_WRITE(RING_SYNC_1(ring->mmio_base), 0); > + if (HAS_VEBOX(ring->dev)) > + I915_WRITE(RING_SYNC_2(ring->mmio_base), 0); > } > > ring->set_seqno(ring, seqno); > -- > 1.8.3.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch