Return-Path: Message-Id: <20130813155831.157308061@goodmis.org> Date: Tue, 13 Aug 2013 11:57:42 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stephane Eranian , Jiri Olsa , Peter Zijlstra , , Ingo Molnar Subject: [48/88] perf: Disable monitoring on setuid processes for regular users References: <20130813155654.069291373@goodmis.org> Content-Disposition: inline; filename=0048-perf-Disable-monitoring-on-setuid-processes-for-regu.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.7-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephane Eranian [ Upstream commit 2976b10f05bd7f6dab9f9e7524451ddfed656a89 ] There was a a bug in setup_new_exec(), whereby the test to disabled perf monitoring was not correct because the new credentials for the process were not yet committed and therefore the get_dumpable() test was never firing. The patch fixes the problem by moving the perf_event test until after the credentials are committed. Signed-off-by: Stephane Eranian Tested-by: Jiri Olsa Acked-by: Peter Zijlstra Cc: Signed-off-by: Ingo Molnar Signed-off-by: Steven Rostedt --- fs/exec.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index 39b6a3c..6f238c8 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1162,13 +1162,6 @@ void setup_new_exec(struct linux_binprm * bprm) set_dumpable(current->mm, suid_dumpable); } - /* - * Flush performance counters when crossing a - * security domain: - */ - if (!get_dumpable(current->mm)) - perf_event_exit_task(current); - /* An exec changes our domain. We are no longer part of the thread group */ @@ -1217,6 +1210,15 @@ void install_exec_creds(struct linux_binprm *bprm) commit_creds(bprm->cred); bprm->cred = NULL; + + /* + * Disable monitoring for regular users + * when executing setuid binaries. Must + * wait until new credentials are committed + * by commit_creds() above + */ + if (get_dumpable(current->mm) != SUID_DUMP_USER) + perf_event_exit_task(current); /* * cred_guard_mutex must be held at least to this point to prevent * ptrace_attach() from altering our determination of the task's -- 1.7.10.4