Return-Path: Message-Id: <20130813155832.337008076@goodmis.org> Date: Tue, 13 Aug 2013 11:57:49 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kees Cook , Anton Vorontsov , David Woodhouse , Anton Vorontsov Subject: [55/88] charger-manager: Ensure event is not used as format string References: <20130813155654.069291373@goodmis.org> Content-Disposition: inline; filename=0055-charger-manager-Ensure-event-is-not-used-as-format-s.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.7-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Kees Cook [ Upstream commit 3594f4c0d7bc51e3a7e6d73c44e368ae079e42f3 ] The exposed interface for cm_notify_event() could result in the event msg string being parsed as a format string. Make sure it is only used as a literal string. Signed-off-by: Kees Cook Cc: stable@vger.kernel.org Cc: Anton Vorontsov Cc: David Woodhouse Signed-off-by: Anton Vorontsov Signed-off-by: Steven Rostedt --- drivers/power/charger-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c index 526e5c9..25b1fea 100644 --- a/drivers/power/charger-manager.c +++ b/drivers/power/charger-manager.c @@ -368,7 +368,7 @@ static void uevent_notify(struct charger_manager *cm, const char *event) strncpy(env_str, event, UEVENT_BUF_SIZE); kobject_uevent(&cm->dev->kobj, KOBJ_CHANGE); - dev_info(cm->dev, event); + dev_info(cm->dev, "%s", event); } /** -- 1.7.10.4