From: Daniel Vetter Subject: Re: [PATCH] drm/i915: make IVB FDI training match spec v3 Date: Mon, 19 Aug 2013 23:10:46 +0200 Message-ID: <20130819211046.GN776@phenom.ffwll.local> References: <1376935495-13063-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 53F81E6205 for ; Mon, 19 Aug 2013 14:10:36 -0700 (PDT) Received: by mail-ea0-f176.google.com with SMTP id q16so2501071ead.7 for ; Mon, 19 Aug 2013 14:10:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 19, 2013 at 05:18:47PM -0300, Paulo Zanoni wrote: > 2013/8/19 Jesse Barnes : > > The existing code was trying different vswing and preemphasis settings > > in the wrong place, and wasn't trying them enough. So add a loop to > > walk through them, properly disabling FDI TX and RX in between if a > > failure is detected. > > > > v2: remove unneeded reg writes, add delays around bit lock checks (Jesse) > > v3: fix TX and RX disable per spec (Paulo) > > fix delays per spec (Paulo) > > make RX symbol lock check match TX bit lock check (Paulo) > > > > Signed-off-by: Jesse Barnes > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch