From: Daniel Vetter Subject: Re: [PATCH] drm/i915: User POSTING_READ and I915_READ_NOTRACE in lcpll code Date: Wed, 21 Aug 2013 23:31:00 +0200 Message-ID: <20130821213100.GK26909@phenom.ffwll.local> References: <1377092985-6993-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id D9A90E5CD5 for ; Wed, 21 Aug 2013 14:30:49 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e52so527838eek.2 for ; Wed, 21 Aug 2013 14:30:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 21, 2013 at 10:59:47AM -0300, Paulo Zanoni wrote: > 2013/8/21 Daniel Vetter : > > If we don't use the return value of a mmio read our coding style is to > > use the POSTING_READ macro. This avoids cluttering the mmio traces. > > > > Similarly for busy loops to wait for a bit to flip we use the _NOTRACE > > variant to avoid filling up the tracebuffers with gunk. Spotted while > > reading some follow-up patches from Paulo. > > > > While at it add the missing posting read in the lcpll enable function > > that Paulo spotted. > > > > Cc: Paulo Zanoni > > Signed-off-by: Daniel Vetter > > Reviewed-by: Paulo Zanoni > > I'm pretty sure I added many other wait_for calls without the _NOTRACE > in the past... Hm, you're right and I even missed one wait_for loop without _NOTRACE in the lcpll code. On further though we only use _NOTRACE consistently in the mmio vfuncs for forcewake and the gt fifo stuff. Which makes sense since those are just the details of how to write a register in the gt. But the actual delay loops in the modeset code are probably rather interesting, so I now think we should keep them ;-) I'll resend with just the posting read stuff. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch