From: Tom Rini Date: Thu, 22 Aug 2013 08:58:14 -0400 Subject: [U-Boot] [PATCH v4 3/4] generic board patch of manual reloc and zero gd_t In-Reply-To: <1482f5f.b7dd.140a3a5eea3.Coremail.fenghua@phytium.com.cn> References: <1376995682-51646-1-git-send-email-fenghua@phytium.com.cn> <1376995682-51646-4-git-send-email-fenghua@phytium.com.cn> <1377130207.5029.87.camel@snotra.buserror.net> <1482f5f.b7dd.140a3a5eea3.Coremail.fenghua@phytium.com.cn> Message-ID: <20130822125814.GI2644@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Aug 22, 2013 at 09:31:35AM +0800, FengHua wrote: > > > > > -----????????????----- > > ?????????: "Scott Wood" > > ????????????: 2013???8???22??? ????????? > > ?????????: "Simon Glass" > > ??????: FengHua , "trini at ti.com" , "U-Boot > > Mailing List" > > ??????: Re: [U-Boot] [PATCH v4 3/4] generic board patch of manual reloc and zero gd_t > > > > On Tue, 2013-08-20 at 23:27 -0600, Simon Glass wrote: > > > Hi David, > > > > > > On Tue, Aug 20, 2013 at 4:48 AM, wrote: > > > > diff --git a/common/board_r.c b/common/board_r.c > > > > index 86ca1cb..1b4bdd2 100644 > > > > --- a/common/board_r.c > > > > +++ b/common/board_r.c > > > > @@ -157,6 +157,13 @@ static int initr_reloc_global_data(void) > > > > */ > > > > gd->env_addr += gd->relocaddr - CONFIG_SYS_MONITOR_BASE; > > > > #endif > > > > +#ifdef CONFIG_NEEDS_MANUAL_RELOC > > > > + /* > > > > + * We have to relocate the command table manually > > > > + */ > > > > + fixup_cmdtable(ll_entry_start(cmd_tbl_t, cmd), > > > > + ll_entry_count(cmd_tbl_t, cmd)); > > > > +#endif /* CONFIG_NEEDS_MANUAL_RELOC */ > > > > > > Should this be done here or in main_loop()? How is this currently done > > > when not using generic board? > > > > It shouldn't be done at all -- let's not revive manual relocations. > > I'll try to get proper relocation working. > > Even the rela relocation of aarch64 works we should keep this here. > The generic board could be used by any other platform that need manual > relocation. No, the point is that manual relocation is legacy and new platforms should be using proper relocation. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: