From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Use POSTING_READ in lcpll code Date: Thu, 22 Aug 2013 16:14:44 +0200 Message-ID: <20130822141444.GO26909@phenom.ffwll.local> References: <20130821213100.GK26909@phenom.ffwll.local> <1377121088-14467-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 78607E740E for ; Thu, 22 Aug 2013 07:14:34 -0700 (PDT) Received: by mail-ea0-f170.google.com with SMTP id h14so926171eak.15 for ; Thu, 22 Aug 2013 07:14:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 21, 2013 at 06:49:31PM -0300, Paulo Zanoni wrote: > 2013/8/21 Daniel Vetter : > > If we don't use the return value of a mmio read our coding style is to > > use the POSTING_READ macro. This avoids cluttering the mmio traces. > > > > While at it add the missing posting read in the lcpll enable function > > that Paulo spotted. > > > > v2: Drop the _NOTRACE changes, tracing such wait_for loops in the modeset > > code might actually be rather useful! > > > > Cc: Paulo Zanoni > > Signed-off-by: Daniel Vetter > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch