From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix lvds/dp panel fitter setting Date: Tue, 27 Aug 2013 13:15:35 +0200 Message-ID: <20130827111535.GK26909@phenom.ffwll.local> References: <1377595449-15928-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id A6708E601D for ; Tue, 27 Aug 2013 04:15:24 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id f15so2204817eak.36 for ; Tue, 27 Aug 2013 04:15:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1377595449-15928-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 27, 2013 at 12:24:09PM +0300, Imre Deak wrote: > If need to enable the panel fitter, the crtc timings have to be > programmed according to the panel's native (fixed) mode. This isn't the > case atm, since after the encoder changes adjusted_mode to fixed > mode the crtc_* timing fields of adjusted_mode will stay at their original > non-native values that the user passed in. This results in a corrupted > output. > > One exception is when we have a second pass of computing encoder configs > due to bandwidth limitation, since then we'll set adjusted_mode.crtc_* > fields to the fixed mode values set in the first pass; so in this case > things will work out. > > Fix this by updating the adjusted_mode.crtc_* fields when we set the > fixed panel mode. > > Signed-off-by: Imre Deak This regression has been introduced in commit 21d8a4756af5fdf4a42e79a77cf3b6f52678d443 Author: Daniel Vetter Date: Fri Jul 12 08:07:30 2013 +0200 drm/i915: fix pfit regression for non-autoscaled resolutions > --- > drivers/gpu/drm/i915/intel_panel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index a43c33b..913cb9d 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -50,6 +50,8 @@ intel_fixed_panel_mode(struct drm_display_mode *fixed_mode, > adjusted_mode->vtotal = fixed_mode->vtotal; > > adjusted_mode->clock = fixed_mode->clock; > + > + drm_mode_set_crtcinfo(adjusted_mode, 0); > } > > /* adjusted_mode has been preset to be the panel's fixed mode */ > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch