Received: from eggs.gnu.org ([2001:4830:134:3::10]:40879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEe72-0003R9-L8 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:40:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEe6v-0000QJ-Ec for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:40:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEe6v-0000Q5-35 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:40:29 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7SBeSGm008275 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Aug 2013 07:40:28 -0400 Date: Wed, 28 Aug 2013 13:40:41 +0200 From: Kevin Wolf Message-ID: <20130828114041.GF2743@dhcp-200-207.str.redhat.com> References: <1377677336-15804-1-git-send-email-mreitz@redhat.com> <1377677336-15804-4-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377677336-15804-4-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > Add tests for qemu-img amend on qcow2 image files. > > Signed-off-by: Max Reitz > --- > This test is numbered 061 for not interfering with my "metadata overlap > checks" series (although I will have to adapt my code to those new checks > anyway when/if they are included in master). > --- > tests/qemu-iotests/061 | 121 +++++++++++++++++++ > tests/qemu-iotests/061.out | 289 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 411 insertions(+) > create mode 100755 tests/qemu-iotests/061 > create mode 100644 tests/qemu-iotests/061.out The existing cases look good. I would add some _check_test_img calls after each amendment, and perhaps include a few cases with non-standard cluster_size etc. during image creation (which would show that your TODO isn't addressed yet). Kevin