From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix lvds/dp panel fitter setting Date: Wed, 28 Aug 2013 18:48:51 +0200 Message-ID: <20130828164851.GB5606@phenom.ffwll.local> References: <1377595449-15928-1-git-send-email-imre.deak@intel.com> <87vc2prg2z.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id CDD8EE5FC5 for ; Wed, 28 Aug 2013 09:48:41 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id b47so3087150eek.17 for ; Wed, 28 Aug 2013 09:48:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87vc2prg2z.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 28, 2013 at 06:27:16PM +0300, Mika Kuoppala wrote: > Imre Deak writes: > > > If need to enable the panel fitter, the crtc timings have to be > > programmed according to the panel's native (fixed) mode. This isn't the > > case atm, since after the encoder changes adjusted_mode to fixed > > mode the crtc_* timing fields of adjusted_mode will stay at their original > > non-native values that the user passed in. This results in a corrupted > > output. > > > > One exception is when we have a second pass of computing encoder configs > > due to bandwidth limitation, since then we'll set adjusted_mode.crtc_* > > fields to the fixed mode values set in the first pass; so in this case > > things will work out. > > > > Fix this by updating the adjusted_mode.crtc_* fields when we set the > > fixed panel mode. > > > > Signed-off-by: Imre Deak > > Daniel, the commit that regressed seem to be > 135c81b8c3c9a70d7b55758c9c2a247a4abb7b64 instead of > 21d8a4756af5fdf4a42e79a77cf3b6f52678d443. > > Reviewed-by: Mika Kuoppala Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch