From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/8] drm/i915: Synchronize pread/pwrite with
 wait_rendering
Date: Fri, 30 Aug 2013 20:39:46 -0700
Message-ID: <20130831033946.GA1088@bwidawsk.net>
References: <1377906241-8463-1-git-send-email-benjamin.widawsky@intel.com>
	<1377906241-8463-2-git-send-email-benjamin.widawsky@intel.com>
	<20130830235030.GP4726@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id DFE1DE5C7D
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 30 Aug 2013 20:39:54 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130830235030.GP4726@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <benjamin.widawsky@intel.com>, Intel GFX <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote:
> On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote:
> > lifted from Daniel:
> > pread/pwrite isn't about the object's domain at all, but purely about
> > synchronizing for outstanding rendering. Replacing the call to
> > set_to_gtt_domain with a wait_rendering would imo improve code
> > readability. Furthermore we could pimp pread to only block for
> > outstanding writes and not for reads.
> > 
> > Since you're not the first one to trip over this: Can I volunteer you
> > for a follow-up patch to fix this?
> > 
> > Recommended-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> This should fail i-g-t...
> -Chris
> 

Daniel, how have I failed your plan?

-- 
Ben Widawsky, Intel Open Source Technology Center