Received: from eggs.gnu.org ([2001:4830:134:3::10]:53459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGWEV-0007lM-Tu for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:40:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGWER-0005N3-Og for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:40:03 -0400 Received: from ssl.serverraum.org ([88.198.40.39]:42870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGWER-0005Mn-Id for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:39:59 -0400 From: Michael Walle Date: Mon, 2 Sep 2013 17:39:55 +0200 References: <1377969760-17489-1-git-send-email-antonynpavlov@gmail.com> <1377969760-17489-2-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1377969760-17489-2-git-send-email-antonynpavlov@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201309021739.55088.michael@walle.cc> Subject: Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov Cc: Peter Crosthwaite , qemu-devel@nongnu.org, Andreas =?utf-8?q?F=C3=A4rber?= Am Samstag, 31. August 2013, 19:22:39 schrieb Antony Pavlov: > qemu_chr_fe_write() is capable of returning 0 > to indicate EAGAIN (and friends) and we don't > handle this. >=20 > Just change it to qemu_chr_fe_write_all() to fix. >=20 > Reported-by: Peter Crosthwaite > Signed-off-by: Antony Pavlov > CC: Peter Crosthwaite > CC: Michael Walle > CC: Andreas F=C3=A4rber > --- > hw/char/milkymist-uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c > index 2e4b5c5..6e4bc20 100644 > --- a/hw/char/milkymist-uart.c > +++ b/hw/char/milkymist-uart.c > @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, > uint64_t value, switch (addr) { > case R_RXTX: > if (s->chr) { > - qemu_chr_fe_write(s->chr, &ch, 1); > + qemu_chr_fe_write_all(s->chr, &ch, 1); > } > s->regs[R_STAT] |=3D STAT_TX_EVT; > break; Acked-by: Michael Walle =2D-=20 Michael