From: Wolfgang Denk Date: Fri, 06 Sep 2013 14:54:16 +0200 Subject: [U-Boot] [PATCH] at91: add support for CDU9G25 board In-Reply-To: <1378465417-18082-1-git-send-email-jiri.prchal@aksignal.cz> References: <1378465417-18082-1-git-send-email-jiri.prchal@aksignal.cz> Message-ID: <20130906125416.331C4380C1D@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jiri Prchal, In message <1378465417-18082-1-git-send-email-jiri.prchal@aksignal.cz> you wrote: > This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND. > > Signed-off-by: Jiri Prchal > --- > board/cdu9g25/Makefile | 48 ++++++++++ > board/cdu9g25/cdu9g25.c | 129 +++++++++++++++++++++++++++ > board/cdu9g25/config.mk | 1 + > boards.cfg | 1 + > include/configs/cdu9g25.h | 217 +++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 396 insertions(+) > create mode 100644 board/cdu9g25/Makefile > create mode 100644 board/cdu9g25/cdu9g25.c > create mode 100644 board/cdu9g25/config.mk > create mode 100644 include/configs/cdu9g25.h Entry to MAINTAINERS file missing. Also, there is a large number of checkpatch warnings that need to be fixed: WARNING: please, no spaces at the start of a line WARNING: space prohibited between function name and open parenthesis '(' ERROR: do not use C99 // comments WARNING: line over 80 characters > diff --git a/include/configs/cdu9g25.h b/include/configs/cdu9g25.h > new file mode 100644 > index 0000000..f8f8008 > --- /dev/null > +++ b/include/configs/cdu9g25.h > @@ -0,0 +1,217 @@ > +/* > + * (C) Copyright 2007-2008 > + * Stelian Pop > + * Lead Tech Design > + * > + * Configuation settings for the CDUNG boards. > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA Please use SPDX ID string here. > +#define CONFIG_HW_WATCHDOG 1 > +#define CONFIG_AT91SAM9_WATCHDOG 1 Please remove values from all logical variables. > +#define CONFIG_BOOTARGS "console=ttyS0,115200 ubi.mtd=root root=ubi0:root rootfstype=ubifs rw g_ether.dev_addr=02:04:25:aa:55:5e g_ether.host_addr=02:04:25:aa:55:5f" > +#define CONFIG_ETHADDR 02:04:de:ad:be:ef > +#define CONFIG_IPADDR 10.0.1.2 > +#define CONFIG_SERVERIP 10.0.1.1 NAK. We don't allow any such kind of static network initialization which would be common for all boards. Please remove all of these. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There was no difference between the behavior of a god and the operations of pure chance..." - Thomas Pynchon, _Gravity's Rainbow_