From: Al Viro Subject: Re: [PATCH 4/4] dcache: don't clear DCACHE_DISCONNECTED too early Date: Mon, 9 Sep 2013 01:46:47 +0100 Message-ID: <20130909004647.GK13318@ZenIV.linux.org.uk> References: <1378579561-26868-1-git-send-email-bfields@redhat.com> <1378579561-26868-5-git-send-email-bfields@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig To: "J. Bruce Fields" Return-path: Content-Disposition: inline In-Reply-To: <1378579561-26868-5-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Sep 07, 2013 at 02:46:01PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > DCACHE_DISCONNECTED should not be cleared until we're sure the dentry is > connected all the way up to the root of the filesystem. It *shouldn't* > be cleared as soon as the dentry is connected to a parent. That will > cause bugs at least on exportable filesystems. Then you probably want this if (!IS_ROOT(pd)) { /* must have found a connected parent - great */ spin_lock(&pd->d_lock); pd->d_flags &= ~DCACHE_DISCONNECTED; spin_unlock(&pd->d_lock); noprogress = 0; to go through all intermediates, clearing DCACHE_DISCONNECTED on all of them; O(depth^2) can suck when we have a long chain of directories... -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html