From: Wolfgang Denk Date: Wed, 11 Sep 2013 00:45:47 +0200 Subject: [U-Boot] [PATCH 04/13] tricorder: add configuration for a flashcard u-boot In-Reply-To: <1378472698-18557-4-git-send-email-andreas.devel@googlemail.com> References: <1378472698-18557-1-git-send-email-andreas.devel@googlemail.com> <1378472698-18557-4-git-send-email-andreas.devel@googlemail.com> Message-ID: <20130910224547.54F64380E12@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Andreas Bie?mann, In message <1378472698-18557-4-git-send-email-andreas.devel@googlemail.com> you wrote: > > The 'flashcard' u-boot configuration has a readonly environment and boots a > bare kernel/initrd to program the device from an clean environment. What exactly is a 'flashcard' ? > +/* environment placement (for NAND), is different for FLASHCARD but does not > + * harm there */ Incorrect multiline comment style. > /* the loadaddr is the same as CONFIG_SYS_LOAD_ADDR, unfortunately the defiend > * value can not be used here! */ Ditto. Please fix globally. > +/* specific environment settings for different use cases > + * FLASHCARD: used to run a rdimage from sdcard to program the device > + * 'NORMAL': used to boot kernel from sdcard, nand, ... And again... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de One difference between a man and a machine is that a machine is quiet when well oiled.