From: Lukasz Majewski Date: Wed, 11 Sep 2013 09:16:16 +0200 Subject: [U-Boot] [PATCH 3/4] dfu: Find DFU alt setting number by passing its name In-Reply-To: <522FF4AC.4020101@denx.de> References: <1378819765-20159-1-git-send-email-l.majewski@samsung.com> <201309101632.53970.marex@denx.de> <20130910171339.5e7cd624@amdc308.digital.local> <201309102320.30600.marex@denx.de> <522FF4AC.4020101@denx.de> Message-ID: <20130911091616.36094452@amdc308.digital.local> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, Marek, > Hello Marek, > > Am 10.09.2013 23:20, schrieb Marek Vasut: > > Dear Lukasz Majewski, > > > >> Hi Marek, > >> > >>> Dear Lukasz Majewski, > >>> > >>>> New function - dfu_get_alt() has been added to dfu core. If > >>>> proper alt setting is present, this function returns its number > >>>> corresponding to passed name. > >>>> > >>>> Change-Id: Icd75f3aa3a6f6e306c77b28cabe620e4e6a253ea > >>>> Signed-off-by: Lukasz Majewski > >>>> --- > >>>> > >>>> drivers/dfu/dfu.c | 12 ++++++++++++ > >>>> include/dfu.h | 1 + > >>>> 2 files changed, 13 insertions(+) > >>>> > >>>> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c > >>>> index 2f1e2af..180d083 100644 > >>>> --- a/drivers/dfu/dfu.c > >>>> +++ b/drivers/dfu/dfu.c > >>>> @@ -414,3 +414,15 @@ struct dfu_entity *dfu_get_entity(int alt) > >>>> > >>>> return NULL; > >>>> > >>>> } > >>>> > >>>> + > >>>> +int dfu_get_alt(const char *name) > >>>> +{ > >>>> + struct dfu_entity *dfu; > >>>> + > >>>> + list_for_each_entry(dfu,&dfu_list, list) { > >>>> + if (!strncmp(dfu->name, name, > >>>> strlen(dfu->name))) > >>>> + return dfu->alt; > >>>> + } > >>>> + > >>>> + return -ENODEV; > >>>> +} > >>>> diff --git a/include/dfu.h b/include/dfu.h > >>>> index 7779710..8838f9c 100644 > >>>> --- a/include/dfu.h > >>>> +++ b/include/dfu.h > >>>> @@ -112,6 +112,7 @@ const char *dfu_get_layout(enum dfu_layout > >>>> l); > >>>> > >>>> struct dfu_entity *dfu_get_entity(int alt); > >>>> char *dfu_extract_token(char** e, int *n); > >>>> void dfu_trigger_reset(void); > >>>> > >>>> +int dfu_get_alt(const char *name); > >>>> > >>>> bool dfu_reset(void); > >>>> > >>>> int dfu_read(struct dfu_entity *de, void *buf, int size, int > >>>> > >>>> blk_seq_num); > >>> > >>> Is this code used anywhere ? > >> > >> Hmm.... By mistake I've added part of my ongoing USB related work > >> to DFU fixes (as you see it is DFU related). > >> > >> Since it is (for now) a dead code, please don't consider this > >> patch. > >> > >> Shall I prepare v2 without this patch or will you be so kind and > >> review other patches in the current patch set? > > > > Rest is OK, I'd like to know Heiko's opinion too before applying > > though. > > Yep, rest of the patches are OK, I tested them on the dxr2 and rut > boards. So from my side they can go in ... without this patch, as > it adds dead code. @Lukasz: Please post this patch again, if you > use this code, thanks! I will, since I'm developing new USB gadget, which reuses DFU write backend. > > bye, > Heiko -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group