From: computersforpeace@gmail.com (Brian Norris) Date: Wed, 11 Sep 2013 13:58:49 -0700 Subject: [PATCH] mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF In-Reply-To: References: <1378916185-19738-1-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <20130911205849.GA4550@ld-irv-0074.broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 11, 2013 at 09:27:11AM -0700, Olof Johansson wrote: > On Wed, Sep 11, 2013 at 9:16 AM, Ezequiel Garcia > wrote: > > This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix > > this build error (with pxa3xx_defconfig or similar): > > > > drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of > > function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration] > > > > Cc: Brian Norris > > Cc: David Woodhouse > > Cc: Olof Johansson > > Cc: Kevin Hilman > > Signed-off-by: Ezequiel Garcia > > Nack. This has already been fixed by you(!), Brian is just sitting on > the patch and not sending it up for some reason. Brian? First, Ezequiel, please CC linux-mtd when you send MTD patches. This didn't show up in my Maintainer inbox because I'm not an ARM maintainer (but you *did* CC their list) :) Second, David hasn't authorized me to send pull requests, so I'm just queueing things up for him. I don't know why David removed this patch (among a few others) from his pull request. David, the following commit (currently in l2-mtd.git) was a dependency for the rest of the pxa3xx series you just sent upstream. You (inadvertently?) left it out when you rebased. Please send a pull request for 3.12-rcX with at least this patch: commit c4287efe67c298b1304c613093371103ac1bbb98 Author: Ezequiel Garcia Date: Mon Aug 12 14:14:46 2013 -0300 mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF There's no need to enclose this code within idef CONFIG_OF, because the OF framework provides no-op stubs if CONFIG_OF=n. Cc: devicetree at vger.kernel.org Signed-off-by: Ezequiel Garcia Signed-off-by: Brian Norris Brian