From: Damien Lespiau Subject: Re: [PATCH 2/5] drm/i915: fix intel_dp_aux_native_read's reply array size Date: Fri, 13 Sep 2013 14:50:37 +0100 Message-ID: <20130913135037.GD24404@strange.amr.corp.intel.com> References: <20130912171523.GD12961@nuc-i3427.alporthouse.com> <1379019832-1526-1-git-send-email-przanoni@gmail.com> <871u4tnkku.fsf@intel.com> <20130913125303.GB24404@strange.amr.corp.intel.com> <878uz0n8ix.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BC7D4E6921 for ; Fri, 13 Sep 2013 06:50:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <878uz0n8ix.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 13, 2013 at 04:41:42PM +0300, Jani Nikula wrote: > On Fri, 13 Sep 2013, Damien Lespiau wrote: > > On Fri, Sep 13, 2013 at 12:21:21PM +0300, Jani Nikula wrote: > >> On Fri, 13 Sep 2013, Paulo Zanoni wrote: > >> > From: Paulo Zanoni > >> > > >> > So far we control all the reads an none of them exceeds the current > >> > limit of 20 bytes, but we never think about this when reviewing > >> > patches, so we may at some point in the future overflow the buffer. > >> > > >> > My initial patch just added a WARN in case we were about to overflow > >> > the buffer, but Chris suggested to make the size of the array dynamic. > >> > >> VLA on stack in kernel gives me an uneasy feeling, but I'll survive. > > > > IIRC sparse will complain about this. Might worth double checking. > > True. > > CHECK drivers/gpu/drm/i915/intel_dp.c > drivers/gpu/drm/i915/intel_dp.c:567:34: error: bad constant expression Also, https://lkml.org/lkml/2013/3/8/486 -- Damein