From: Russell King - ARM Linux Subject: Re: [PATCH 181/228] cpufreq: move freq change notifications to cpufreq core Date: Fri, 13 Sep 2013 16:53:13 +0100 Message-ID: <20130913155313.GA12758@n2100.arm.linux.org.uk> References: Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=VfC54Uo4ZaqMTNAPWugKJQljDUjGNNBUSaP6u9W0114=; b=oOZaHn83ci+0khXHJTXllPnx2M3DDlttY6zEstz+KEsVIIwJcrCIiEBjPx7+6bVGs43rWZN2DGN4bK4ye0fdFsU8K/xm9tGyqgy0fLjAUA3WvaE44/mG2Wone682kjAbxOaLzWXUHcd1/QpsksgZcv1qXokSHGNgXLJSN+DvQtM=; Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, Sep 13, 2013 at 06:32:07PM +0530, Viresh Kumar wrote: > + read_lock_irqsave(&cpufreq_driver_lock, flags); > + notify = !(cpufreq_driver->flags & CPUFREQ_ASYNC_NOTIFICATION); > + read_unlock_irqrestore(&cpufreq_driver_lock, flags); I don't think this needs to be read under a lock - if this bit changes dynamically, then there's something very wrong.