From: Russell King - ARM Linux Subject: Re: [PATCH 106/228] cpufreq: integrator: don't initialize part of policy that is set by core too Date: Fri, 13 Sep 2013 17:10:59 +0100 Message-ID: <20130913161059.GD12758@n2100.arm.linux.org.uk> References: <6d8d406ebca886e5147191cc8c333d926ef9eb30.1379063063.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=d0BzhnauiAbA4ZgTUtzJnwqgxRdwzRaw3HUkRE7mBKY=; b=pDiXpXL/DHkG7PNK41CuRgRPB5Rdicl/95VkLrDZA5i17q22dwRB9IZDd2q4muERmMshHBSSVcS3AlhAWLzFoPIFmTH7rS0OKy5WeGOwVgNgtq/KNTp1PCkE2ZuhYK0GyFeh43KD386Tc5ajND6VbaricviMtMFgRLSGNqWd7qs=; Content-Disposition: inline In-Reply-To: <6d8d406ebca886e5147191cc8c333d926ef9eb30.1379063063.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, Sep 13, 2013 at 06:30:52PM +0530, Viresh Kumar wrote: > Many common initializations of struct policy are moved to core now and hence > this driver doesn't need to do it. This patch removes such code. > > Most recent of those changes is to call ->get() in the core after calling > ->init(). > > Cc: Russell King > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/integrator-cpufreq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c > index 8152a9b..babf3e4 100644 > --- a/drivers/cpufreq/integrator-cpufreq.c > +++ b/drivers/cpufreq/integrator-cpufreq.c > @@ -181,10 +181,9 @@ static int integrator_cpufreq_init(struct cpufreq_policy *policy) > { > > /* set default policy and cpuinfo */ > - policy->cpuinfo.max_freq = 160000; > - policy->cpuinfo.min_freq = 12000; > + policy->max = policy->cpuinfo.max_freq = 160000; > + policy->min = policy->cpuinfo.min_freq = 12000; > policy->cpuinfo.transition_latency = 1000000; /* 1 ms, assumed */ > - policy->cur = policy->min = policy->max = integrator_get(policy->cpu); This patch actually changes things - the description is misleading. Please explain why this change - which results in different values for policy->min and policy->max doesn't cause any functional difference. Thanks.