From: Andrew Lunn Subject: Re: [PATCH 195/228] cpufreq: kirkwood: remove calls to cpufreq_notify_transition() Date: Fri, 13 Sep 2013 18:18:20 +0200 Message-ID: <20130913161820.GM19363@lunn.ch> References: <0a512914fd48b2d6db685446f88b9a096eff79a1.1379063063.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <0a512914fd48b2d6db685446f88b9a096eff79a1.1379063063.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Lunn On Fri, Sep 13, 2013 at 06:32:21PM +0530, Viresh Kumar wrote: > - if (freqs.old != freqs.new) { > - local_irq_disable(); > - > - /* Disable interrupts to the CPU */ > - reg = readl_relaxed(priv.base); > - reg |= CPU_SW_INT_BLK; > - writel_relaxed(reg, priv.base); > - > - switch (state) { > - case STATE_CPU_FREQ: > - clk_disable(priv.powersave_clk); > - break; > - case STATE_DDR_FREQ: > - clk_enable(priv.powersave_clk); > - break; > - } Hi Viresh I see you removed the test that the old and the new frequency are different. Is this guaranteed by the core? Because if not, you can lockup the CPU. The call to cpu_do_idle() will never return. Thanks Andrew