From: Lukasz Majewski Date: Fri, 13 Sep 2013 18:05:16 +0200 Subject: [U-Boot] [PATCH v3 2/3] dfu: ram support In-Reply-To: <20130913153736.GG6479@book.gsilab.sittig.org> References: <5eb509735b5bd634043bbb8f56d088073773b7b8.1379055112.git.afzal.mohd.ma@gmail.com> <201309131551.22535.marex@denx.de> <20130913153736.GG6479@book.gsilab.sittig.org> Message-ID: <20130913180516.1e5165a3@amdc308.digital.local> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gerhard, > On Fri, Sep 13, 2013 at 15:51 +0200, Marek Vasut wrote: > > > > Dear Afzal Mohammed, > > > > [...] > > > > > +int dfu_fill_entity_ram(struct dfu_entity *dfu, char *s) > > > +{ > > > + char *st; > > > + > > > + dfu->dev_type = DFU_DEV_RAM; > > > + st = strsep(&s, " "); > > > + if (strcmp(st, "ram")) { > > > + error("unsupported device: %s\n", st); > > > + return -ENODEV; > > > + } > > > + > > > + dfu->layout = DFU_RAM_ADDR; > > > + dfu->data.ram.start = (void *)simple_strtoul(s, &s, 16); > > > + dfu->data.ram.size = simple_strtoul(++s, &s, 16); > > > > This ++s, &s is quite crazy ;-) > > Actually it's not just a neat trick, but instead it's not > guaranteed to work. It's an inviation for problems that you > don't need. > > The order in which arguments for the call get evaluated isn't > specified, so behaviour is uncertain here. Read: the > construction happens to work by coincidence for individual > setups, but isn't correct and need not work elsewhere, and may > break in arbitrary ways at any occasion, and then is hard to > track down since things may "seem to work" often enough or the > bug won't show up when you are diagnosing the problem. > > The code needs to get fixed before getting picked up. Doing the > increment in a separate instruction is cheap and simple, the > terse form is wrong. It was me, who by some obscure reason introduced this faulty (non standard) code. And probably Afzal copied it from dfu_mmc.c file. So f...g embarrassing... However the fix for that code at dfu_mmc.c file was already posted to ML. > > > virtually yours > Gerhard Sittig -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group