From: Marek Vasut Date: Sun, 15 Sep 2013 18:44:15 +0200 Subject: [U-Boot] [PATCH v4] usb: new board-specific USB init interface In-Reply-To: <1378825807-9471-1-git-send-email-m.zalega@samsung.com> References: <1375786242-11734-1-git-send-email-m.zalega@samsung.com> <1378825807-9471-1-git-send-email-m.zalega@samsung.com> Message-ID: <201309151844.16041.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mateusz Zalega, > This commit unifies board-specific USB initialization implementations > under one symbol (usb_board_init), declaration of which is available in > usb.h. > > New API allows selective initialization of USB controllers whenever needed. > > Signed-off-by: Mateusz Zalega > Signed-off-by: Kyungmin Park > Reviewed-by: Lukasz Majewski > Cc: Marek Vasut > Cc: Lukasz Majewski > Change-Id: Ia78a1378f30a55dd14598c9a1a1b4b8a762e2cd8 > --- > Changes since RFC (v1): > - NVIDIA Tegra doesn't postpone its USB init anymore > - board_usb_init()'s sole argument name was shortened > - networking code comment style (/* blurb...) dropped > - squashed RFC changes so that patch won't break bisect > > v2 changes: > - commit message fixup > > v3 changes: > - added 'index' argument to perform selective port initialization > > v4 changes: > - board_usb_init_fail() renamed to board_usb_cleanup() > - board_usb_cleanup() accepts controller index and init type > - DFU and UMS commands don't init all USB controllers anymore > - minor related fixes & refactorization > --- Looks pretty much OK. Did you test it on a few platforms? I'd like to apply this for -next anyway, since the MW is long closed. Best regards, Marek Vasut