From: Olaf Hering Subject: Re: [PATCH v2] unmodified_drivers: enable unplug per default Date: Wed, 18 Sep 2013 15:37:22 +0200 Message-ID: <20130918133722.GB31884@aepfle.de> References: <1377867576-10356-1-git-send-email-olaf@aepfle.de> <1378731936.19967.123.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1378731936.19967.123.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Sep 09, Ian Campbell wrote: > On Fri, 2013-08-30 at 14:59 +0200, Olaf Hering wrote: > > Since xen-3.3 an official unplug protocol for emulated hardware is > > available in the toolstack. The pvops kernel does the unplug per > > default, so it is safe to do it also in the drivers for forward ported > > xenlinux. > > Currently its required to load xen-platform-pci with the module > > parameter dev_unplug=all, which is cumbersome. > > Not sure who is supposed to review/ack/nack this change. > > Wouldn't you want to add a way to stop the unplug? As it stands I think > you can request it do less, but not nothing. I think adding a new dev_unplug=never case would fix this case. I will send another version of this patch. Olaf