From: Tom Rini Date: Thu, 19 Sep 2013 15:06:22 -0400 Subject: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition In-Reply-To: <20130909154146.532CB380E12@gemini.denx.de> References: <1378670088-17602-1-git-send-email-robherring2@gmail.com> <20130909140629.4614D380DE2@gemini.denx.de> <522DE2FF.2080001@gmail.com> <20130909154146.532CB380E12@gemini.denx.de> Message-ID: <20130919190622.GA5273@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote: > Dear Rob, > > In message <522DE2FF.2080001@gmail.com> you wrote: > > > > What do I do with current boards that are wrong? I should make all these > > Good question... > > > boards have build errors or fix them to use 1000 which may break them at > > runtime depending on their possible misuse of CONFIG_SYS_HZ? > > > > include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 > > /* decr freq: 1 ms ticks */ > > include/configs/M5271EVB.h:#define CONFIG_SYS_HZ > > 1000000 > > include/configs/METROBOX.h:#define CONFIG_SYS_HZ > > 100 /* decr freq: 1 ms ticks */ > > include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 10000 > > include/configs/idmr.h:#define CONFIG_SYS_HZ > > (50000000 / 64) > > include/configs/mini2440.h:#define CONFIG_SYS_HZ > > 1562500 > > include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 > > include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ > > ((V_SCLK) / (2 << CONFIG_SYS_PTV)) > > include/configs/omap730p2.h:#define CONFIG_SYS_HZ > > ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV)) > > include/configs/rsk7203.h:#define CONFIG_SYS_HZ > > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > > include/configs/rsk7264.h:#define CONFIG_SYS_HZ > > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > > include/configs/rsk7269.h:#define CONFIG_SYS_HZ > > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > > include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 > > /* incrementer freq: 3.6864 MHz */ > > include/configs/versatile.h:#define CONFIG_SYS_HZ > > (1000000 / 256) > > Hm... which of these boards are actually still being maintained? > > KAREF and METROBOX are PPC systems, and the comment suggests that the > value is actually just a typo. Here it should be harmless to change > this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest > might actually be dead? > > Guess we should have their builds break and make the board maintainers > fix them. If they don't (because the boards are unmaintained), we > will drop the board code from the repo. Actually breaking them will cause hell on the folks building everything. Lets correct the ones we can correct easily and poke maintainers for the rest so we know what we can/should move to orphaned or just drop. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: