From: Tom Rini Date: Sat, 21 Sep 2013 08:06:25 -0400 Subject: [U-Boot] bootm: use BOOTM_STATE_OS_CMDLINE flag for plain bootm In-Reply-To: <1378463035-14030-1-git-send-email-paul.burton@imgtec.com> References: <1378463035-14030-1-git-send-email-paul.burton@imgtec.com> Message-ID: <20130921120625.GJ5273@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Sep 06, 2013 at 11:23:55AM +0100, Paul Burton wrote: > A plain bootm used to call the architecture specific boot function with > no flags, but was modified by commit 35fc84fa "Refactor the bootm > command to reduce code duplication" to call the architecture specific > boot function multiple times with various flags in sequence. The > BOOTM_STATE_OS_CMDLINE flag was not used, indeed it seems that at least > ARM prepares the command line on BOOTM_STATE_OS_PREP. However on MIPS > since commit 59e8cbdb "MIPS: bootm: refactor initialisation of kernel > cmdline" the command line is not prepared in response to a > BOOTM_STATE_OS_PREP flag, only on BOOTM_STATE_OS_CMDLINE or a call with > no flags. The end result is that a combination of those 2 commits leads > to MIPS boards booting kernels with no command line arguments. > > An extra invocation of the architecture specific boot function with > BOOTM_STATE_OS_CMDLINE fixes this. > > Signed-off-by: Paul Burton Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: