From: Dan Carpenter Date: Tue, 24 Sep 2013 19:59:58 +0000 Subject: Re: checkpatch guide for newbies Message-Id: <20130924195958.GO6247@mwanda> List-Id: References: <20130923090100.GE6192@mwanda> <5241CB44.8080004@ahsoftware.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Senna Tschudin Cc: Alexander Holler , Bjorn Helgaas , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" On Tue, Sep 24, 2013 at 09:29:49PM +0200, Peter Senna Tschudin wrote: > I was about to disagree because I've never seen variables named a, b > or c, but I found that there are at least 2238 variables named a, b or > c in linux-next. This is not good. > In XGIfb_mode_rate_to_ddata() we have: int B, C, D, F, temp, j; The A and E variables were removed when the code was refactored. ;P Places like this are fairly rare in the kernel outside of the staging/ directory. There are lots of times where a single letter variable name is very natural. char c; C is terse. This is explained in Documentation/CodingStyle. regards, dan carpenter