From: Daniel Vetter Subject: Re: [PATCH] drm/i915/dp: do not write DP_TRAINING_PATTERN_SET all the time Date: Mon, 30 Sep 2013 15:15:15 +0200 Message-ID: <20130930131515.GN26592@phenom.ffwll.local> References: <1380283844-30766-1-git-send-email-jani.nikula@intel.com> <20130927151311.GG14385@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 04CA4E66CE for ; Mon, 30 Sep 2013 06:14:58 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id d49so2643825eek.6 for ; Mon, 30 Sep 2013 06:14:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130927151311.GG14385@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 27, 2013 at 06:13:11PM +0300, Ville Syrj=E4l=E4 wrote: [snip] > OK, so it looks like I didn't find anything really wrong with this > patch itself, and now the code matches the spec much better, so: > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. I agree with Ville's observation and beating the dp link train code into better shape would be pretty terrific! -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch