Received: from eggs.gnu.org ([2001:4830:134:3::10]:48306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQdGP-00012J-UQ for qemu-devel@nongnu.org; Mon, 30 Sep 2013 09:11:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQdGJ-0001WD-Vr for qemu-devel@nongnu.org; Mon, 30 Sep 2013 09:11:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQdGJ-0001W4-O3 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 09:11:43 -0400 Date: Mon, 30 Sep 2013 15:10:56 +0200 From: Igor Mammedov Message-ID: <20130930151056.32699e7f@nial.usersys.redhat.com> In-Reply-To: <1380452123-5989-2-git-send-email-mst@redhat.com> References: <1380452123-5989-1-git-send-email-mst@redhat.com> <1380452123-5989-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de On Sun, 29 Sep 2013 13:58:24 +0300 "Michael S. Tsirkin" wrote: > This is so qom headers can use it without pulling in > extra headers. >=20 > Reviewed-by: Paolo Bonzini > Signed-off-by: Michael S. Tsirkin > --- > include/qemu/typedefs.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index a4c1b84..46c3599 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -7,6 +7,7 @@ typedef struct QEMUTimer QEMUTimer; > typedef struct QEMUTimerListGroup QEMUTimerListGroup; > typedef struct QEMUFile QEMUFile; > typedef struct QEMUBH QEMUBH; > +typedef struct Error Error; > =20 > typedef struct AioContext AioContext; > =20 fc19 seems to ok with it but rhel6/gcc-4.4.7-4 isn't ./configure --enable-kvm --target-list=3Dx86_64-softmmu,x86_64-linux-user In file included from /qemu/include/qapi/visitor.h:18, from qapi-visit.h:20, from qapi-visit.c:18: /qemu/include/qapi/error.h:23: error: redefinition of typedef =E2=80=98Erro= r=E2=80=99 /qemu/include/qemu/typedefs.h:10: note: previous declaration of =E2=80=98Er= ror=E2=80=99 was here