Received: from eggs.gnu.org ([2001:4830:134:3::10]:47954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRJ37-00043c-NP for qemu-devel@nongnu.org; Wed, 02 Oct 2013 05:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRJ32-0002ML-9C for qemu-devel@nongnu.org; Wed, 02 Oct 2013 05:48:53 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:52491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRJ32-0002MA-23 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 05:48:48 -0400 Received: by mail-we0-f172.google.com with SMTP id w61so636298wes.3 for ; Wed, 02 Oct 2013 02:48:47 -0700 (PDT) Date: Wed, 2 Oct 2013 11:48:44 +0200 From: Stefan Hajnoczi Message-ID: <20131002094844.GK2142@stefanha-thinkpad.redhat.com> References: <1380017641-29820-1-git-send-email-riegamaths@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380017641-29820-1-git-send-email-riegamaths@gmail.com> Subject: Re: [Qemu-devel] [PATCH] block: use correct filename for error report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dunrong Huang Cc: Kevin Wolf , qemu-devel , Stefan Hajnoczi On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: > The content filename point to will be erased by qemu_opts_absorb_qdict() > in raw_open_common() in drv->bdrv_file_open() > > So it's better to use bs->filename. > > Signed-off-by: Dunrong Huang > --- > block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) The same issue affects the rest of the function: #ifndef _WIN32 if (bs->is_temporary) { assert(filename != NULL); unlink(filename); } #endif Do you want to send a separate patch to fix this? Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan