Received: from eggs.gnu.org ([2001:4830:134:3::10]:60419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVivn-0004up-HO for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:15:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVivh-0006JI-IJ for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVivh-0006JB-BI for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:15:29 -0400 Date: Mon, 14 Oct 2013 17:18:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20131014141800.GB19575@redhat.com> References: <1381391779-27718-1-git-send-email-pingfank@linux.vnet.ibm.com> <1381391779-27718-3-git-send-email-pingfank@linux.vnet.ibm.com> <20131010091614.GA7089@redhat.com> <52567453.50204@redhat.com> <20131010094109.GA7295@redhat.com> <52567782.1080706@redhat.com> <20131010114116.GF7582@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori On Fri, Oct 11, 2013 at 10:59:40AM +0800, liu ping fan wrote: > On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin wrote: > > On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: > >> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: > >> >> > Are you sure? This is not done for any other compat property. > >> >> > > >> >> > Paolo > >> > It's done if we use the property from C. > >> > See PCI_HOST_PROP_PCI_HOLE64_SIZE. > >> > > >> > You want compiler to catch errors, that's > >> > much better than a runtime failure. > >> > >> I agree, but I think there should be no need to use the property from C. > >> > >> Paolo > > > > Well this patchset does use it from C. > > If it's done it needs a macro. > > hpet.h is the ideal place to put the macro, so pc.c can see it. But > what about PC_COMPAT_1_7 in pc.h? I think it is not right to include > hpet.h. Why not? > So can I do not use marco in pc.h? > > Thanks and regards, > Ping Fan