Received: from eggs.gnu.org ([2001:4830:134:3::10]:44224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWoF9-00038Q-JR for qemu-devel@nongnu.org; Thu, 17 Oct 2013 10:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWoF1-0005TV-6W for qemu-devel@nongnu.org; Thu, 17 Oct 2013 10:08:03 -0400 Received: from mail-bk0-x22f.google.com ([2a00:1450:4008:c01::22f]:44237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWoF0-0005TN-WB for qemu-devel@nongnu.org; Thu, 17 Oct 2013 10:07:55 -0400 Received: by mail-bk0-f47.google.com with SMTP id mx12so827868bkb.6 for ; Thu, 17 Oct 2013 07:07:54 -0700 (PDT) Date: Thu, 17 Oct 2013 16:07:51 +0200 From: Stefan Hajnoczi Message-ID: <20131017140751.GA25474@stefanha-thinkpad.redhat.com> References: <2eb3cc487b16a5b1e478b4f3d139382dabf15e58.1381512252.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2eb3cc487b16a5b1e478b4f3d139382dabf15e58.1381512252.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, Oct 11, 2013 at 02:17:36PM -0400, Jeff Cody wrote: > + if (image_size > VHDX_MAX_IMAGE_SIZE) { > + fprintf(stderr, "Image size too large; max of 64TB\n"); Please use error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB") instead of fprintf(). There are other instances in this file that should be converted too.