Received: from eggs.gnu.org ([2001:4830:134:3::10]:47982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYZZ0-0008Ay-94 for qemu-devel@nongnu.org; Tue, 22 Oct 2013 06:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYZYu-0008Ma-Sv for qemu-devel@nongnu.org; Tue, 22 Oct 2013 06:51:50 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:57370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYZYu-0008MQ-Kf for qemu-devel@nongnu.org; Tue, 22 Oct 2013 06:51:44 -0400 Received: by mail-la0-f48.google.com with SMTP id ev20so784634lab.7 for ; Tue, 22 Oct 2013 03:51:42 -0700 (PDT) Date: Tue, 22 Oct 2013 14:48:40 +0400 From: Antony Pavlov Message-Id: <20131022144840.cebd01b2edd126a96d611aec@gmail.com> In-Reply-To: References: <1378537467-13471-1-git-send-email-antonynpavlov@gmail.com> <1378537467-13471-5-git-send-email-antonynpavlov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v5 4/5] hw/arm/digic: add UART support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alex Dumitrache , Peter Crosthwaite , Giovanni Condello , g3gg0 , QEMU Developers , Paolo Bonzini , Andreas =?ISO-8859-1?Q?F=E4rber?= On Thu, 17 Oct 2013 18:54:28 +0100 Peter Maydell wrote: > On 7 September 2013 08:04, Antony Pavlov wrote: > > Signed-off-by: Antony Pavlov > > --- a/hw/arm/digic_boards.c > > +++ b/hw/arm/digic_boards.c > > @@ -26,6 +26,13 @@ > > #include "hw/boards.h" > > #include "exec/address-spaces.h" > > #include "hw/arm/digic.h" > > +#include "hw/block/flash.h" > > +#include "hw/loader.h" > > +#include "sysemu/sysemu.h" > > + > > +#define DIGIC4_ROM0_BASE 0xf0000000 > > +#define DIGIC4_ROM1_BASE 0xf8000000 > > +# define DIGIC4_ROM_MAX_SIZE 0x08000000 >=20 > Stray extra spaces here. If you fix those then: > Reviewed-by: Peter Maydell Yes, my bad! But this fragment (defining DIGIC4_ROM* macros) is misplaced. It will go to= the "add NOR ROM support" in the next patchseries version. --=20 --=A0 Best regards, =A0 Antony Pavlov