From: broonie@kernel.org (Mark Brown) Date: Tue, 29 Oct 2013 10:58:34 -0700 Subject: [PATCH 00/19] Enable various Renesas drivers on all ARM platforms In-Reply-To: <1422562.0L87CDt5Gd@avalon> References: <1383004027-25036-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1577821.Q7gttkPE2J@avalon> <20131029172331.GA20251@sirena.org.uk> <1422562.0L87CDt5Gd@avalon> Message-ID: <20131029175834.GD20251@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 29, 2013 at 06:29:59PM +0100, Laurent Pinchart wrote: > On Tuesday 29 October 2013 10:23:31 Mark Brown wrote: > > On Tue, Oct 29, 2013 at 06:05:53PM +0100, Laurent Pinchart wrote: > > > The first one is that I can't compile-test all those drivers on all > > > architectures. The spi-sh-msiof driver, for instance, uses > > > io(read|write)(16| > > Which architectures are these and is there not a symbol we can depend on > > for them? > arch/cris for instance. We can use readl/writel instead (maybe it would be > time to rationalize and document the I/O accessors across all architectures, > but that's another topic). It'd certainly be sensible, or adding a config option to depend on if you rely on these functions. > My point is that there might be other issues that I won't be able to easily > catch. This would break compilation for everybody for no reason, as the > drivers are useless on non-SuperH, non-ARM platforms. That's why I believe > COMPILE_TEST would be a better option as a first step. Yes, it would - please do that. Note that it won't stop anyone running into build issues on other architectures though, it's just about stopping Kconfig noise. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: